Cs352 software engineering ii how to make it better

Info icon This preview shows pages 16–21. Sign up to view the full content.

View Full Document Right Arrow Icon
CS352 Software Engineering II
Image of page 16

Info iconThis preview has intentionally blurred sections. Sign up to view the full version.

View Full Document Right Arrow Icon
How to Make it Better? Don’t create a battleground. The goal is better software, not who’s right. Lay out the ground rules. Which review comments must be addressed before proceeding in the life cycle? What are valid reasons for missing a review? Who can cancel a review? Maintain professionalism. Don’t take the criticism personally and offer only technical advice that will improve the code Dr. Omar Hamdy Spring 2011 17 Be careful with the scope of the review. Determine the size range or the scope of the code being reviewed. Cisco code review study suggests review fewer than 200-400 lines of code (LOC) at a time Document what happens. Write everything down, especially decisions and action items. Establish quantifiable goals . Avoid subjective terms and always fix targets in measurable terms. CS352 Software Engineering II
Image of page 17
Social Effects! The Ego Effect Teach the Reviewer: if ( “integrate”.equals( str ) ) { ... } Systematic Personal Growth Dr. Omar Hamdy Spring 2011 18 Hurt Feelings & Big Brother Effects CS352 Software Engineering II
Image of page 18

Info iconThis preview has intentionally blurred sections. Sign up to view the full version.

View Full Document Right Arrow Icon
Review What? Usually code reviews focus on certain areas: – Inefficient and/or poorly performing code – Security issues Dr. Omar Hamdy Spring 2011 19 – Incorrect business logic – Incorrect use of project or industry best practices and standards – Just about anything else! CS352 Software Engineering II
Image of page 19
References http://smartbear.com/resources/cc/11_Best_ Practices_for_Peer_Code_Review.pdf http://www.nws.noaa.gov/oh/hrl/developers.ht ml http://smartbear.com/resources/cc/book/socia Dr. Omar Hamdy Spring 2011 20 l-aspects-of-review.pdf http://www.kgsepg.com/project-id/10161- software-engineering-coding-and-testing- code-review http://code.google.com/p/jupiter-eclipse- plugin/ CS352 Software Engineering II
Image of page 20

Info iconThis preview has intentionally blurred sections. Sign up to view the full version.

View Full Document Right Arrow Icon
Reading Carefully Read Chapters 15 & 16 Dr. Omar Hamdy Spring 2011 21 CS352 Software Engineering II
Image of page 21
This is the end of the preview. Sign up to access the rest of the document.

{[ snackBarMessage ]}

What students are saying

  • Left Quote Icon

    As a current student on this bumpy collegiate pathway, I stumbled upon Course Hero, where I can find study resources for nearly all my courses, get online help from tutors 24/7, and even share my old projects, papers, and lecture notes with other students.

    Student Picture

    Kiran Temple University Fox School of Business ‘17, Course Hero Intern

  • Left Quote Icon

    I cannot even describe how much Course Hero helped me this summer. It’s truly become something I can always rely on and help me. In the end, I was not only able to survive summer classes, but I was able to thrive thanks to Course Hero.

    Student Picture

    Dana University of Pennsylvania ‘17, Course Hero Intern

  • Left Quote Icon

    The ability to access any university’s resources through Course Hero proved invaluable in my case. I was behind on Tulane coursework and actually used UCLA’s materials to help me move forward and get everything together on time.

    Student Picture

    Jill Tulane University ‘16, Course Hero Intern