{[ promptMessage ]}

Bookmark it

{[ promptMessage ]}

CS352-Lecture_Notes-OH-L03

Improved communication more opportunities for

Info iconThis preview shows pages 15–21. Sign up to view the full content.

View Full Document Right Arrow Icon
Improved communication. More opportunities for interaction tend to lead the team toward improved communication. CS352 Software Engineering II
Background image of page 15

Info iconThis preview has intentionally blurred sections. Sign up to view the full version.

View Full Document Right Arrow Icon
Challenges Time. Some peer reviews take a long time. Preparation. Reading unfamiliar code and correlating that code to unfamiliar documentation takes programmers away om coding. Dr. Omar Hamdy Spring 2011 16 from coding. Initial frustration. If team members are not familiar with peer reviews, the experience can be frustrating for all participants The need to show commitment. Although random peer reviews offer some benefit, that level of commitment is questionable. CS352 Software Engineering II
Background image of page 16
How to Make it Better? Don’t create a battleground. The goal is better software, not who’s right. Lay out the ground rules. Which review comments must be addressed before proceeding in the life cycle? What are valid reasons for missing a review? Who can cancel a review? Maintain professionalism. Don’t take the criticism personally Dr. Omar Hamdy Spring 2011 17 and offer only technical advice that will improve the code Be careful with the scope of the review. Determine the size range or the scope of the code being reviewed. Cisco code review study suggests review fewer than 200-400 lines of code (LOC) at a time Document what happens. Write everything down, especially decisions and action items. Establish quantifiable goals . Avoid subjective terms and always fix targets in measurable terms. CS352 Software Engineering II
Background image of page 17

Info iconThis preview has intentionally blurred sections. Sign up to view the full version.

View Full Document Right Arrow Icon
Social Effects! • The Ego Effect • Teach the Reviewer: if ( “integrate”.equals( str ) ) { . .. } Dr. Omar Hamdy Spring 2011 18 • Systematic Personal Growth CS352 Software Engineering II
Background image of page 18
Review What? • Usually code reviews focus on certain areas: – Inefficient and/or poorly performing code ecurity issues Dr. Omar Hamdy Spring 2011 19 – Security issues – Incorrect business logic – Incorrect use of project or industry best practices and standards – Just about anything else! CS352 Software Engineering II
Background image of page 19

Info iconThis preview has intentionally blurred sections. Sign up to view the full version.

View Full Document Right Arrow Icon
References http://smartbear.com/resources/cc/11_Best_ Practices_for_Peer_Code_Review.pdf http://www.nws.noaa.gov/oh/hrl/developers.ht ml ttp://smartbear.com/resources/cc/book/socia Dr. Omar Hamdy Spring 2011 20 http://smartbear.com/resources/cc/book/socia l-aspects-of-review.pdf http://www.kgsepg.com/project-id/10161- software-engineering-coding-and-testing- code-review http://code.google.com/p/jupiter-eclipse- plugin/ CS352 Software Engineering II
Background image of page 20
Reading Dr. Omar Hamdy Spring 2011 21 CS352 Software Engineering II
Background image of page 21
This is the end of the preview. Sign up to access the rest of the document.

{[ snackBarMessage ]}

Page15 / 21

Improved communication More opportunities for interaction...

This preview shows document pages 15 - 21. Sign up to view the full document.

View Full Document Right Arrow Icon bookmark
Ask a homework question - tutors are online